Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
weboob
weboob
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 174
    • Issues 174
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 48
    • Merge Requests 48
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • weboob
  • weboobweboob
  • Merge Requests
  • !459

Closed
Opened Apr 15, 2020 by ZeHiro@ZeHiro
  • Report abuse
Report abuse

[hsbc] Fix retrieval of parent account for deffered debit cards.

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

This MR fixes a change in the way accounts attached to credit cards are displayed. The current code leads to the following error:

Bug(hsbc): 'NoneType' object has no attribute 'group'
Traceback (most recent call last):
  File "/home/tonio/.local/lib/python3.7/site-packages/weboob/core/bcall.py", line 106, in backend_process
    for subresult in result:
  File "/home/tonio/.local/lib/python3.7/site-packages/weboob/tools/application/base.py", line 297, in _do_complete_iter
    for i, sub in enumerate(res):
  File "/home/tonio/Code/weboob/modules/hsbc/module.py", line 54, in iter_accounts
    for account in self.browser.iter_account_owners():
  File "/home/tonio/Code/weboob/modules/hsbc/browser.py", line 271, in iter_account_owners
    parent_id = re.match(r'^(\d*)?(\d{11}.EUR)$', card[1]).group(2)  # ids in the HTML have 5 numbers added at the beginning, catch only the end
AttributeError: 'NoneType' object has no attribute 'group'

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://git.weboob.org/ZeHiro/devel.git" "fix-parent-id-retrival"
git checkout -b "ZeHiro/devel-fix-parent-id-retrival" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "ZeHiro/devel-fix-parent-id-retrival"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: weboob/weboob!459