crangheard authored Jun 01, 2023 and Antoine Le Gonidec committed Jun 09, 2023

Since flake 5.0.0, the exit code is returned instead of exiting.
The requirement upgrade occurred here ec63e7e1 and causes the bug.

asttokens does not fill some fields properly for f-strings so we can't check
them now

Rationale
---------

This has the advantage that modules can be imported just like any
standard Python module.
AbstractModule/Browser/Page will simply become useless over time.
Modules can be migrated to regular imports at different times.

Transition
----------

$WEBOOB_DATADIR/$WEBOOB_VERSION will contain a "weboob_modules" prefix,
instead of directly modules folders.
For users using HTTP repos like updates.weboob.org, transition will be
smooth as "weboob-config update" will just (re)install modules referred
to by $WEBOOB_BACKENDS.

TODO:
* play nice with sources.list
* weboob: remove Abstract*
    * this should be done when all modules are migrated

ntome authored Oct 12, 2020 and hydrargyrum committed Oct 28, 2020

But it's pep8 rule keeps application-imports in the same group as
relative-imports. Changing it is not a matter of configuration but defining
our own style, which is tedious as it would require a setuptools entrypoint
just for that, so we inject manually the style.

ntome authored Jul 09, 2020 and hydrargyrum committed Aug 26, 2020

Constructions like:

    a and b or c
    1 << 2 & 3

are discouraged because precedence isn't obvious at first sight.
Parentheses must be added to make code explicit.

Vincent Ardisson authored Aug 05, 2020 and hydrargyrum committed Aug 07, 2020

flake8 is capable of running checks in parallel if we give it multiple files.

A star-mapping in a dict returns a None key.

ntome authored May 19, 2020 and hydrargyrum committed Jun 03, 2020

Also, don't print a backtrace when flake8 failed, because it's not
exceptional and it confuses readers.

ntome authored May 18, 2020 and hydrargyrum committed Jun 03, 2020

This can be accepted for compacity:

    foo = [{
        1: 1,
        2: 2,
    }]

Rather than forcing to do:

    foo = [
        {
            1: 1,
            2: 2,
        },
    ]

ntome authored May 04, 2020 and hydrargyrum committed May 07, 2020

This was rejected:

    [
        (a),
    ]

because last token of last element is "a", not ")". So we have to skip
closing parentheses before reaching the trailing comma.

Also, simply use "generic_visit" instead of calling "visit" on sub nodes
ourselves.

ntome authored Nov 21, 2019 and hydrargyrum committed May 07, 2020

New checks will be applied on files containing a comment such as
"# flake8: compatible".