kmartins authored Jun 06, 2023 and Antoine Le Gonidec committed Jun 09, 2023

id can have `-` in it, and `\w+` does
not match them. We change for `.+`

Thomas Toumeyragues authored Apr 25, 2023 and Quentin Defenouillere committed May 02, 2023

Information regarding stocks' general assembly was wrongly
considered as an account

lbellebouche authored Feb 21, 2023 and Romain Bignon committed Mar 01, 2023

Url an xpath have changed for card fetching
in professionnal account space. Cards were not
scraped anymore without rasing any exception.

Thomas Toumeyragues authored Jan 24, 2023 and Antoine Le Gonidec committed Jan 26, 2023

Filter error because we did not ignore non-investment
items that do not have quantity, unitvalue, etc.

lbellebouche authored Jan 03, 2023 and Antoine Le Gonidec committed Jan 26, 2023

Remove BrowserForbidden, in BankStatementPage.check_error()
raised in iter_subscription in this specific case.
This Exception occured when account owner
has not asked for enabling e-document feature.

Thomas Toumeyragues authored Jan 09, 2023 and Thomas Touhey committed Jan 10, 2023

Societe Generale becomes SG

Thomas Toumeyragues authored Dec 12, 2022 and Thomas Touhey committed Jan 10, 2023

Error 'fiabilisation_coordonnees' occurs when
the user needs to validate its contact information
on its personal space

New types of pro loans are fetched since a few days. A few particular
cases were not covered. Some loans must be skipped since they contain
almost no information (Crédit Bail Mobilier or Location Option d'Achat
for example). Pro loan page can sometimes return an unavailable status
even on the website, handling of that message have been added to prevent
the for loop fetching the accounts stopping. Also added a default
NotAvailable for an element of the label that is called
"informationFacultative" and, as its name says, this value of this key
is not always provided in the JSON. Finally, added a condition to skip
some PER and PERCO. These are accounts that have no information on the
website except a label and a contract number. Clicking on them on the
website leads us to an error page.

When fetching short-term credits, we can have "Autorisation de découvert
(Convention de Trésorerie Courante)" accounts. Those accounts only have
an iban and a "maximum amount". These are not regular loans so we skip
them. Also added defaults for these short and medium-term credits,
data for attributes last_payment_amount and last_payment_date (or next_)
can be null on the website for some loans.

Some pages that contains pro loans (short term, and medium/long term)
were not scraped before.
Also a page that contains life insurances and per accounts was missing.
This MR should handle them.

Thomas Touhey authored May 25, 2022 and ntome committed Jul 04, 2022

Since most such requests work and only some fail with
this reason, we suppose its a temporary unavailability
and add a retry.

npaillasson authored May 23, 2022 and ntome committed Jun 13, 2022

Management of unhandled errors in the spge part of the module.
Sometimes in the spge part of the module,
we get the value 'nok' for the key ‘state’ in the json
for different 'reasons', which can be
ENCADREMENT_KYC_PREAVIS, ENCADREMENT_KYC_POST_PREAVIS, INSCRIP_OBL,
in this case we raise ActionNeeded because the user has to fill in
some information on the bank website.
We also manage the ‘err_is’ and ‘err_tech’ cases in which we
raise BrowserUnavailabe as in the browser of the main module.
Sometimes the key 'reason' has the value 'FIABILISATION_TS'.
To manage this case in the main module there is a function named
check_skippable_action_needed.
However, in some cases the function does not seem to be sufficient
to pass FIABILISATION_TS state.
In this case, we have the key 'chgtnivauth' in the returned json.
During login, this key is also present when an SCA is required.
It is likely that, in some cases, an SCA is also required to pass
the 'FIABILISATION_TS' state.
So, in the main module, I add the possibility to trigger
an SCA if the json obtained in the check_skippable_action_needed
function contains the chgtnivauth key.
We do not have a PSU to test the solution regarding FIABILISATION_TS.

Venceslas Roullier authored May 17, 2022 and ntome committed May 30, 2022

When reaching the subscriptions, the user sometimes reaches
errors; those are similar to some errors reached in the
accounts pages. We thus reuse a similar method to handle
reached errors.
Unencountered errors will have to be added manually later.

Not tested : sca prevents us to really test,
and our sgpe creds are down.

sfartit authored Apr 14, 2022 and ntome committed Apr 28, 2022

When the user has more than one card we were always returning the coming
of the first one.

kmartins authored Apr 05, 2022 and ntome committed Apr 28, 2022

It seems like when we reach the ProfilePage we can have
the same error related to expired password on AccountPage

hicham kouz authored Mar 08, 2022 and ntome committed Mar 16, 2022

update the Bill URLs, iter_subscriptions and iter_documents.

basestring, range, long, url*, parse*, unicode, html_unescape
also, remove some obsolete sys.version checks

Fixes a regression: iter_recipients func definition was modified in
societegenerale but not inside the sgpe child.

jlouvel authored Nov 04, 2021 and hydrargyrum committed Nov 24, 2021

If the URL contained in the storage is the recipients URL,
the website returns a JSON telling us we're not logged.
We're now using this JSON to set a logged property on the
concerned pages. Also changed the "on_load" methods for a
manual check_error method.

Louise Zanier authored Sep 03, 2021 and hydrargyrum committed Sep 13, 2021

Sometimes, we get several cards even though we asked for one.
They have the same number but some might not have a date. Instead
of getting the first card, we get the first one with a date.

Yasmine Idwy authored Aug 02, 2021 and hydrargyrum committed Aug 13, 2021

- self.response.json()['donnees'] = null so there is no
number to get (get_number()) therefore no comings

Damien Mat Jedrzejewski authored Feb 11, 2021 and hydrargyrum committed Feb 26, 2021

When reloading state and requesting the last page visited,
we are usally logged out.
If that page was EasyTransferPage, in that case, it is now a JSON,
instead of the regular HTML when already logged.

This is now handled with a special logged property.

Damien Mat Jedrzejewski authored Feb 08, 2021 and hydrargyrum committed Feb 12, 2021

When reloading state and requesting the last page visited,
when that page is one of the one in json_pages.py,
we are usally logged out.
This is handled in AccountJsonPage with a special Logged property.
But it needs to be as well in the other pages.
We do that by introducing a LoggedDetectionMixin,
inherited by a SGPEJsonPage, common to all subsequent pages.

Damien Mat Jedrzejewski authored Jan 28, 2021 and hydrargyrum committed Feb 12, 2021

To better avoid problems when changing things not common
to SGEntreprise and SGProfessional,
inheritance scheme is changed.

A common SGPEBrowser still exists. It takes in
common login steps from SocieteGeneraleLogin,
and common Pro/Ent navigation.
But SGProfessionalBrowser and SGEnterpriseBrowser are now
each inheriting separately from SGPEBrowser.

It bears importance for the few differences in 2FA handling
for Ent, where it is systematic, compared to Pro.

Also, dead code is deleted (browser and pages' side).
And a few commenting is added.

Artyom Chvostov authored Jan 27, 2021 and hydrargyrum committed Feb 12, 2021

Initially only the case of "PLAFOND_SIGNATURE_DEPASSE" had to be added.
But after discussions, the need to fix other cases emerged.