Yacine BOUHALA authored Sep 12, 2023 and Damien Mat Jedrzejewski committed Oct 17, 2023

Sometimes we encounter a poorly constructed date
 that looks like this: / / 0, which causes us
 to encounter a bug.

sfartit authored Jun 02, 2023 and Antoine Le Gonidec committed Jun 09, 2023

AppGone page doesn't always mean that we are logged out.
we can just continue fetching invests.

if we encounter it in the login the behavious is not changed.

sfartit authored May 15, 2023 and Quentin Defenouillere committed Jun 01, 2023

Amount class takes credit and debit columns. here it was taking amount
and gross_amount. Hence the negative transactions amounts.

sfartit authored Mar 15, 2023 and Romain Bignon committed Apr 11, 2023

This page contains info about the loans and it wasn't scrapped before.

Hicham Kouz authored Feb 16, 2023 and Florian Duguet committed Feb 17, 2023

add obj_date to transactions.

Heddy authored Nov 18, 2022 and Florian Duguet committed Dec 19, 2022

Espace Patrimoine has become Espace patrimoine.
use lower-case to handle both.

When fetching account to retrieve investments,
balance may be missing, add default in this case.

Yacine BOUHALA authored Sep 20, 2022 and Florian Duguet committed Dec 19, 2022

At HSBC the accounts are categorized in three categories:
 current, savings, and investment, however there are rare
 cases where the current accounts have the word investment
 in their labels, which leads us to a typing error,
 it happens that these accounts have the same id with
 the investment accounts(our case) due to the fact that
the first one is considered as a checking type account
 and the other one as a market type.
 According to the tests made on several HSBC accounts,
 this bank always uses the word invest for investment
accounts but never the full word "investment"
which explains the presence and use of the word
 investment in a current account.
A correction has been made to match only the accounts
 that have invest in their labels.

Thomas Toumeyragues authored Aug 31, 2022 and Florian Duguet committed Dec 19, 2022

Previous MR updated balance during iter_history instead
of iter_accounts.
Background: balance for Life insurances provided on the dashboard
is not the most updated value, according to hsbc website.
The value provided on LifeInsurancesPage is the most
accurate.

Thomas Toumeyragues authored Aug 30, 2022 and ntome committed Sep 05, 2022

The balance for Life insurances provided on the dashboard
is not the most updated value, according to hsbc website.
The value provided on LifeInsurancesPage is the most
accurate.

those are dangerous and can hide real exceptions

Heddy authored Mar 30, 2022 and ntome committed Apr 28, 2022

Life insurances details pages need a token in request.
We use 2 new forms because forms are create by javascript
with field token already filled.

For PEA accounts we have to take care about 2 things:
- leave "espace tiers" before
- return empty list if we try to fetch investments
for other people's accounts

basestring, range, long, url*, parse*, unicode, html_unescape
also, remove some obsolete sys.version checks

Stéphane Sobucki authored Jun 09, 2021 and hydrargyrum committed Jun 30, 2021

Because relogin or ActionNeeded can happen during the handle_otp, solely
relying on the presence of the otp config value may cause some issue. We
might already have validated the otp once but we will run handle_otp
once again.

Also using locate_browser() when handling otp can lead to weird
behaviour. In our case it leads to unavailable page.

To fix this we don't use locate_browser() anymore, instead we store the
otp_form_data and otp_validation_url to use them in handle_otp. We also
use their presence in states to be sure that it's the first time we call
handle_otp.

Closes: 337@sibi

Stéphane Sobucki authored May 17, 2021 and hydrargyrum committed Jun 05, 2021

Handle more login error messages, updated XPath for errors in
LoginPage's `on_load()` method.

Additionaly, added login errors check in `end_login()` to avoid
FormNotFound exception due to a blocked account access.

nvergnac authored May 17, 2021 and hydrargyrum committed May 24, 2021

Investment details page for market/pea account is only available with an OTP access

If we try to navigate to the investments space without the OTP access, we break the navigation

nvergnac authored Mar 24, 2021 and hydrargyrum committed Apr 08, 2021

Removed hardcoded unitvalue and quantity for euro funds

Added original_currency

Damien Mat Jedrzejewski authored Mar 04, 2021 and hydrargyrum committed Apr 08, 2021

Only payment accounts are returned by the site
when visiting through the MCI access.
So is_here condition of AccountsPage is updated accordingly.

Damien authored Mar 17, 2021 and hydrargyrum committed Apr 08, 2021

HSBC displaying SCPI accounts like this:
SCPI EP - PP XXXXXXXXX.EUR
SCPI ER5 - PP XXXXXXXXX.EUR
The id (XXXXXXXXX.EUR) can be shared among SCPI accounts, to distinguish them , now id look like this:
'XXXXXXXXX.SCPIEPPP' instead of 'XXXXXXXX.SCPI'
'XXXXXXXXX.SCPIER5PP' instead of 'XXXXXXXX.SCPI'

Florent Viard authored Feb 24, 2021 and hydrargyrum committed Apr 08, 2021

... that could appear when going on some lifeinsurances accounts

When we are trying to go on some lifeinsurances account pages,
sometimes we get instead an intermediary blank page with a form.

It looks like that a javascript browser fingerprint has to be done to
fill the form and submit it.
Otherwise, when we submit without it or a wrong value, we are redirected
back to the home page.

I'm not completely sure why it is sometimes needed, and if ever we would
go to the right page if ever the fingerprint was correct.

I guess that might be the case for empty or special state life
insurances.

Anyway, for the moment, we just properly detect that we arrived on this
page and five up for this life insurance account.

Florent Viard authored Feb 24, 2021 and hydrargyrum committed Apr 08, 2021

My guess is that SSMOUV is probably related to "Sans Mouvement"
accounts.
(ie accounts without any activity in the last years)

Florent Viard authored Feb 23, 2021 and hydrargyrum committed Apr 08, 2021

if we are already inside the accounts or ownerlist pages

Florent Viard authored Feb 23, 2021 and hydrargyrum committed Apr 08, 2021

... that is already used by browsers to avoid nasty issues

Sometimes browser function "is_here" could be confused if one page is an
ancestor of another one, as an "isinstance" with the Parent class will
also match with the children class

Damien Mat Jedrzejewski authored Mar 17, 2021 and hydrargyrum committed Mar 24, 2021

Detected after username submission.
Since we weren't handling this case, login was proceeding
to 2FA notification instead of stopping here.

Damien Mat Jedrzejewski authored Sep 07, 2020 and hydrargyrum committed Sep 23, 2020

2FA to be done in a navigator by user