Yacine BOUHALA authored Jul 24, 2023 and Damien Mat Jedrzejewski committed Jul 31, 2023

An update was introduced in hsbc accounts
 in order  to ensure that loans belong to the "Loan" class
 rather than the "Account" class.
 However, while doing so,
 we forgot to assign an owner to the loans,
 which is something we do with regular accounts.
 As a result, this has created a bug in the code.

sfartit authored Jul 07, 2023 and Quentin Defenouillere committed Jul 17, 2023

Loans should be of class `Loan` instead of `Account`.

sfartit authored Jun 02, 2023 and Antoine Le Gonidec committed Jun 09, 2023

AppGone page doesn't always mean that we are logged out.
we can just continue fetching invests.

if we encounter it in the login the behavious is not changed.

sfartit authored Mar 15, 2023 and Romain Bignon committed Apr 11, 2023

This page contains info about the loans and it wasn't scrapped before.

Hicham Kouz authored Feb 08, 2023 and Quentin Defenouillere committed Feb 10, 2023

we should go to the owner account page before visiting scpi page,
to avoid being redirected to AppGonePage.

Yacine BOUHALA authored Sep 29, 2022 and Florian Duguet committed Dec 19, 2022

it seems that in hsbc when we look
 for the url of the validation otp
 we concatenate the otp_url value
 with 'https://www.hsbc.fr' except
 that this one is already complete
 so we get something like
 'https://www.hsbc.frhttps//.........'
 which leads us to an error

Thomas Toumeyragues authored Aug 31, 2022 and Florian Duguet committed Dec 19, 2022

Previous MR updated balance during iter_history instead
of iter_accounts.
Background: balance for Life insurances provided on the dashboard
is not the most updated value, according to hsbc website.
The value provided on LifeInsurancesPage is the most
accurate.

Thomas Toumeyragues authored Aug 30, 2022 and ntome committed Sep 05, 2022

The balance for Life insurances provided on the dashboard
is not the most updated value, according to hsbc website.
The value provided on LifeInsurancesPage is the most
accurate.

Thomas Toumeyragues authored Aug 16, 2022 and ntome committed Aug 22, 2022

On HSBC website, PERP accounts are considered like Life
Insurances. We can get PERP accounts history the same way
we do for Life Insurances.

Thomas Toumeyragues authored Aug 09, 2022 and ntome committed Aug 12, 2022

Sometimes when history is not available for a life insurance
account we end up on life_insurance_useless page. It does
not display any history on transactions nor have a method
for it.

Thomas Toumeyragues authored Aug 09, 2022 and ntome committed Aug 12, 2022

We get ReadTimeout error while getting history on several
type of accounts: checking, loan, pea, life_insurance.

Heddy authored May 18, 2022 and ntome committed May 23, 2022

bad domain name for otp url
which causes an error during SSL
certificat verifaction

Heddy authored Mar 30, 2022 and ntome committed Apr 28, 2022

Life insurances details pages need a token in request.
We use 2 new forms because forms are create by javascript
with field token already filled.

For PEA accounts we have to take care about 2 things:
- leave "espace tiers" before
- return empty list if we try to fetch investments
for other people's accounts

kmartins authored Mar 07, 2022 and ntome committed Mar 09, 2022

The validation otp is not done on the
BASEURL. So we now use hsbc.fr for the url
in otp_validation_url

basestring, range, long, url*, parse*, unicode, html_unescape
also, remove some obsolete sys.version checks

Stéphane Sobucki authored Jun 09, 2021 and hydrargyrum committed Jun 30, 2021

Because relogin or ActionNeeded can happen during the handle_otp, solely
relying on the presence of the otp config value may cause some issue. We
might already have validated the otp once but we will run handle_otp
once again.

Also using locate_browser() when handling otp can lead to weird
behaviour. In our case it leads to unavailable page.

To fix this we don't use locate_browser() anymore, instead we store the
otp_form_data and otp_validation_url to use them in handle_otp. We also
use their presence in states to be sure that it's the first time we call
handle_otp.

Closes: 337@sibi

Stéphane Sobucki authored Jun 08, 2021 and hydrargyrum committed Jun 30, 2021

The old BASEURL is not reachable anymore. There was no big issue with
the browser since it would switch to the new BASEURL if needed.

Handle new message: 'service is temporarily unavailable'.

Closes: 18054@sibi

Stéphane Sobucki authored May 27, 2021 and hydrargyrum committed Jun 05, 2021

commit 8087d2f6dea023946894032a8fde7c1bac6438ce added the handling of
more error cases and a check for error messages at the `end_login()`
step to fix `FormNotFound` errors.

At this step, error messages and the message upon a succesful login are
located under the same XPath. So, we might raise false login errors.

To avoid false positives, we check whether we are logged in or not before handling
errors.

Stéphane Sobucki authored May 18, 2021 and hydrargyrum committed Jun 05, 2021

In some scenarios, relogin are triggered. If it happens inside
`handle_otp`, the otp value stored in config will not be cleared.

The consequence is that we will try to validate the otp once again, even
though we might not even be on the right page.

To fix that we reset the otp value to its default value manually.

Stéphane Sobucki authored May 17, 2021 and hydrargyrum committed Jun 05, 2021

Handle more login error messages, updated XPath for errors in
LoginPage's `on_load()` method.

Additionaly, added login errors check in `end_login()` to avoid
FormNotFound exception due to a blocked account access.

Christophe François authored May 04, 2021 and hydrargyrum committed Jun 05, 2021

If we don't go to the account's owner's space before we try to go to the
life insurances website, we arrive on the "useless page".

nvergnac authored May 10, 2021 and hydrargyrum committed May 24, 2021

We cannot have access to investment pages sometimes, we need to stop the
navigation before it crashes

Christophe François authored Apr 07, 2021 and hydrargyrum committed Apr 08, 2021

For some accounts, the form to go to the invests page redirects to a
404. There is no detail available on the website for these accounts.

Florent Viard authored Feb 24, 2021 and hydrargyrum committed Apr 08, 2021

... that could appear when going on some lifeinsurances accounts

When we are trying to go on some lifeinsurances account pages,
sometimes we get instead an intermediary blank page with a form.

It looks like that a javascript browser fingerprint has to be done to
fill the form and submit it.
Otherwise, when we submit without it or a wrong value, we are redirected
back to the home page.

I'm not completely sure why it is sometimes needed, and if ever we would
go to the right page if ever the fingerprint was correct.

I guess that might be the case for empty or special state life
insurances.

Anyway, for the moment, we just properly detect that we arrived on this
page and five up for this life insurance account.

Florent Viard authored Feb 23, 2021 and hydrargyrum committed Apr 08, 2021

if we are already inside the accounts or ownerlist pages

Damien Mat Jedrzejewski authored Mar 17, 2021 and hydrargyrum committed Mar 24, 2021

Detected after username submission.
Since we weren't handling this case, login was proceeding
to 2FA notification instead of stopping here.

Damien Mat Jedrzejewski authored Sep 07, 2020 and hydrargyrum committed Sep 23, 2020

2FA to be done in a navigator by user

Christophe François authored Jun 04, 2020 and hydrargyrum committed Jun 17, 2020

Some wealth accounts are now available only on the linebourse space. The
current way of fetching accounts results in an error message.

The linebourse space is not accessible with the current authentication
so for now we catch the error so the accounts can be fetched (although
without investments details and history).

sinopsysHK authored Apr 22, 2020 and hydrargyrum committed May 07, 2020

Adapt with new hsbc way to reference each accounts accross the links.
Update the way we distinguish Checking account page from Card account
page

Closes: issue #381 58824@sibi