- Jul 29, 2018
-
-
The iframe destination tends to change, and isn't always an AccountList page. However, we test the existence of CGUs on the AccountsList page, and this is why we need to ensure we are on a AccountList page beforehand. Closes: 14153@sibi 13797@sibi
-
Looking at the website, you can see that some transactions are duplicates. So it is normal to have some, since it is what is send. But sometimes, some requests send have the same transaction list, even if they had different parameters/data. So there are some more duplicates. It happens only for the card type transactions. They are compared to be sure they does not bring duplicates. It is pretty easy since their labels always have the same format: 'TOT DIF %MONTH%'. And the duplicates one have the same amount too. The rest is checked just to be sure. Closes: 6257@zendesk
-
The infamous "Cliquer pour déplier ou plier le détail de l’opération" is back! This is linked to the commit 6d41bfaf that removes this piece of some transaction labels ; but it turns out that now it's not located in parts[0] instead of parts[1]. I first remove all empty strings and then look for the string that we want to get rid of ; if it's there I remove it from the list, this way it is more dynamic that parts[0] or parts[1]. Tested with CIC and creditmutuel connections. Closes: 6378@zendesk, 6382@zendesk, 6381@zendesk, 6398@zendesk
-
Before the patch the number and label look like "Avoir sous mandat LCL 00426346639P". Now it is only 00426346639P. closes: 6173@zendesk
-
The patch adds strid params. Whithout the params the website is frequently in error. closes: 13847@sibi
-
-
update origin account and recipient account label for transfer check get them on init transfer page example: 'Compte Courant Joint' on account page can become 'Compte Courant' on transfer page
-
-
Transfer origin account balance can be negative Closes: 16355@sibi
-
An issue caused errors in boobank: "transaction XXX has missing foreign info" So I removed the original_currency since there is no original_amount.
-
At first the account id was taken from an option tag. But this id was used to look for accounts that begin with this id. Now it looks for the id in the account table. This case conflicts with 1 table student loan which needs the id in the option tag. Changing the order of the ifs is enough. Closes: 15258@sibi Closes: 15334@sibi Closes: 15335@sibi Closes: 6592@zendesk Closes: 6334@zendesk
-
Closes: 14369@sibi
-
-
Closes: 9101@sibi
-
Closes: 9334@sibi
-
During add recipient, iban can be on td[2] or td[3] in recipient table search for iban col and recipient label is on col - 1
-
A weboob contributor proposed a patch to fix the Date when empty: "For the field date, the module use the column "Date de réception" and "Date de valeur" if the first is empty. But Spirica uses "-" when the cell is empty, so no date is returned and boobank uses today's date as default value." I adapted his merge request since we now use CleanText instead of TableCell for iter_history, with the connection I have the symbols='-' does not change any date but maybe in some cases it will prevent boobank from returning today's date by default.
-
Several elements have changed on the Spirica website: - the "Tout afficher" button disappeared, - the forms to get the transactions list were modified, - the forms to get investments for each transaction changed. This patch corrects history for each account as well as the respective invests.
-
Add another xpath to find button to validate otp.
-
Closes: 15542@sibi "Montant net" has been fixed in a previous commit, now it's "Montant brut"
-
get on transfer page because estimated value on account page can be different need estimated value to validate origin account to do transfer Closes: 15168@sibi 15200@sibi 15553@sibi 15554@sibi 10417@sibi 13715@sibi 15566@sibi 15231@sibi 15371@sibi
-
A recurring problem with bnporc is that sometimes you may not have the good transactions list. It may be truncated a lot. For example, from 50 transactions, you had only 5. Because of that, in the backend some transactions become deleted because of one update with the bad transactions. I tried to fix it by copying the website, since you never had bad transactions on it. First, I changed the 'typeReleve' from 'Comptable' to 'Previsionnel' because it is the only type the website is using. And I added some parameters to the history request. The same ones are used to go on the transaction page and to get the json data. I tested a lot on connections, knowing the right and the wrong history state. Since I applied the patch, I had not once the wrong state. Closes: 5663@zendesk Closes: 6219@zendesk Closes: 6225@zendesk Closes: 6229@zendesk Closes: 6115@zendesk
-
Saving account can't do transfer to external recipients Saving account can't receive transfer when limit is reached Closes: 13881@sibi 13123@sibi
-
-
Up to now only Cards accounts had a obj_number which may lead to failures in matching_accounts for the backend since the value is implicitly filled with the account.id Closes: 6022@zendesk
-
-
In some case, you may have only one market type account. If so, the website does not show a page with the list of one account but directly the details of this account. Most of the time, getting the number in the account label is enough to recognize it in the iter_accounts. But sometime you have custom account label, so it is not enough. That is why the entire account name is retrieved. Closes: 13125@sibi Closes: 12518@sibi Closes: 13576@sibi Closes: 12610@sibi Closes: 12871@sibi Closes: 11832@sibi Closes: 11912@sibi Closes: 11913@sibi Closes: 11867@sibi Closes: 11750@sibi Closes: 11749@sibi Closes: 11580@sibi Closes: 11715@sibi Closes: 11714@sibi
-
The real debit date was not fetched. Instead, the rdate was put into the date field.
-
They were completely skipped. There's a link to access previous month history. However, the debit dates all seem wrong, same for coming.
-
It's useless and less readable
-
Closes: 6189@zendesk
-
on axabanque page, pea history leads to an error page (in HTTP ...) get history on netfinca bourse page for pea liquidity and pea market Closes: 12819@sibi 12814@sibi 11620@sibi 11492@sibi 13455@sibi 11618@sibi 12821@sibi 11643@sibi 9251@sibi 11496@sibi 12813@sibi 9192@sibi 9203@sibi 9750@sibi 11123@sibi 11495@sibi 12818@sibi
-
In iter_investments, the xpath selecting the correct <tr> for TableElement was too restrictive (td count >7) whereas some invests may have only 7 columns. This is corrected with a count >= 7. Closes: 6171@zendesk
-
Closes: 13778@sibi
-
On transfer validation page, get reason with cut 'Motif : ' and skip html comment. Get reason to check label error with 'transfer_check_label' instead of assert without message. remove unused parameter on handle response: - amount - reason - exec_date Closes: 14399@sibi 8735@sibi 4979@sibi
-
-
-
In some case, you may have a student loan with only one account. It is handled by item_loan.
-
Closes: 5944@zendesk
-
Website transfer state can be "Soumis à la banque". Check if keywords ('Exécuté', 'Soumis') is in webiste transfer state message instead of check that state message is in keywords tell user than transfer was done even though it wasn't is better than tell users that transfer state is bug even though it was done Closes: 14390@sibi
-