__str__ is reimplemented in terms of __unicode__ and __repr__ else.

hydrargyrum authored Feb 14, 2017 and Romain Bignon committed Feb 18, 2017

To spare modules' FILL_OBJECTS having to fill every Thumbnail field, a
Thumbnail is considered complete if its data is present.
Else, the "thumbnail" field of an Image could get transformed into
NotAvailable simply because its "title" isn't set.

hydrargyrum authored Jan 24, 2017 and Romain Bignon committed Jan 25, 2017

Since Python 2.7 is the minimum version supported,
collections.OrderedDict is guaranteed to exist and there is no need to
reimplement it.

In Python 2, __repr__ and __str__ shouldn't return unicode.
This caused a problem for example when logging-debug a filter on Thumbnail.url,
as the logger couldn't encode the unicode repr.

flake8 --select W391,E302,E301,E304

autopep8 can't fix W391 even though it claims it can.
Fixed using a simple custom script.

Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>

BaseImage was extracted from the gallery capability and
refactored to inherit from BaseFile.
As I did not look further into the gallery capability, I left
the original BaseImage there.
I'm aware that it's not an healthy situation, but it seems
to be used only by modules using ICapGallery and hopefully
should not have any consequences for now

Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>