Romain Bignon authored Mar 17, 2019 and hydrargyrum committed Mar 28, 2019

It happens for example in weboob.capabilities.account.Account which
gives None as default value.

Maxime Gasselin authored Oct 19, 2018 and Romain Bignon committed Nov 10, 2018

We need to give error parameter to find_object

26504@sibi

Laurent Bachelier authored Aug 10, 2018 and hydrargyrum committed Sep 16, 2018

Or at least make code look slightly better

Python's enums are not extensible, values can't be added and they can't
be subclassed. This is problematic if weboob devel adds new values,
because stable weboob will not be able to use them. They would need to
be replaced by a default value or None, which loses information.

Instead, implement custom enums that contain plain constants and support
adding values aftewards.

Python 2's json module stringifies values using the builtin str()
function, so any custom __str__ function will be used instead of the
number representation:

  json.dumps([AccountType.CHECKING])

will then return invalid JSON "[CHECKING]" instead of "[1]". By
enforcing use of int.__str__, the previous behavior is restored.

See https://bugs.python.org/issue18264 (it's fixed in Python 3).

Python 3.4 added new Enum types that enforce a value belonging to the
enumeration.
This commit retires our homemade enum and use Python's Enum type.
Python 2 compatibility is achieved with "enum34" package.

Housing and Calendar capabilities are updated to use those new enums.

Quentin Defenouillere authored Jun 06, 2018 and Romain Bignon committed Jun 09, 2018

Since the currencies dictionary is ordered, it is preferable to first
iter over this dictionary and then iter over the curtexts in order to
prevent mismatches.
For example, the get_currency method selected the 'PEN' currency in several
cases: if the text contains 'en EUR', the curtexts list will be
['en', 'EUR'] and if we iterate over curtexts first, 'en' will be
matched with 'PEN' because of the "if curtext in currency" line without
ever trying to match 'EUR' with 'EUR'.

Therefore, curtexts are now strictly matched with currencies since
most websites use the ISO-4217 norm anyways and because it is better to
return None than to match wrong currencies such as peruvian sols.
Example: if the text contains 'CHAUDE', it will match it with 'AUD'
(australian dollars) with is wrong, whereas "if curtext == currency" is
stricter but avoids false matches.

Closes: 5548@zendesk

Baptiste Delpey authored Dec 21, 2017 and Romain Bignon committed May 05, 2018

don't crash handling non-mandatory fields
instead we fill them with the new FetchError EmptyField

Sylvie Ye authored Feb 20, 2018 and Romain Bignon committed Mar 03, 2018

'F' and 'fr.' regex for LUF(currency) is not enough accurate.
For exemple: hsbc life insurance id contains 'F' and 'EUR'.

Closes: 4387@zendesk

Etienne Lachere authored Jan 18, 2018 and Romain Bignon committed Feb 04, 2018

It seems common that websites shows
the currency between parenthesis, it allows the filter to parse them
correctly.

Since those classes store some class-level declared fields (Field and
URL) in a dictionary and are not present as attributes, those fields are
not present in dir() even though __getattr__ will find them.
By reimplementing __dir__, they can be discovered as ordinary
attributes.

By default, PyYAML dumps all fields, giving poor results for BaseObject
and its fields:

  !!python/unicode paris: !!python/object:weboob.capabilities.calendar.Query
    _fields: !!python/object/apply:collections.OrderedDict
    - - - url
        - !!python/object:weboob.capabilities.base.StringField
          _creation_counter: 0
          doc: url
          types: !!python/tuple
          - &id003 !!python/name:__builtin__.unicode
          value: !!python/object:weboob.capabilities.base.NotLoadedType {}
  etc.

When pickle methods are provided, PyYAML uses them.
In this case, a BaseObject will be dumped as a plain old dict.

In Python2 anyway, bytes is an alias for str.

__str__ is reimplemented in terms of __unicode__ and __repr__ else.

The syntax for using a metaclass is different in python2 and python3,
and there are existing helpers.

Add six as a dependency in setup.py.

TODO this is less efficient on python2

Some functions changed return type from python2 to python3

TODO: not everything is tested, a full review is needed + run is needed

With: futurize -w -1 weboob

To make compatible code for py2/py3 using methods like __str__, it's
better to avoid unicode_literals, since __str__/__repr__ must always
return the native str type of the python version.

When calling copy() method which does a shallow copy, the _fields dict
was copied, but not its values (which are Field instances). Since the
real content of the BaseObject is stored in the Field instances, the
values were shared instead of being shallow-copied:

    obj2 = obj1.copy()
    obj2.foo = 'bar'  # would modify obj1.foo

Since _fields is kind of read-only, it's useless not to copy the Field
instances.

Vincent Ardisson authored Jan 26, 2017 and Romain Bignon committed Jan 28, 2017

fix "weboob.capabilities.base: use OrderedDict for currencies"

hydrargyrum authored Jan 24, 2017 and Romain Bignon committed Jan 25, 2017

Since Python 2.7 is the minimum version supported,
collections.OrderedDict is guaranteed to exist and there is no need to
reimplement it.

Baptiste Delpey authored Apr 08, 2016 and Romain Bignon committed Dec 03, 2016

if True, prevents budgea backend to delete the transactions

[core] clean my crap a tuple containing a single value have to include a comma, even though there is only one value −