Skip to content
  1. Sep 17, 2018
  2. Sep 16, 2018
    • Laurent Bachelier's avatar
      ing: PEP8 fixes · c3bd3e3e
      Laurent Bachelier authored and hydrargyrum's avatar hydrargyrum committed
      c3bd3e3e
    • Quentin Defenouillere's avatar
      [ing] Added condition to get_isin() method · 084e7808
      Quentin Defenouillere authored and Romain Bignon's avatar Romain Bignon committed
      Some ING connections are crashing because we try to get an element of an
      empty xpath:
      self.doc.xpath('//div[@id="headFiche"]//span[@id="test3"]/text()')[0].split(' - ')[0].strip()
      IndexError: list index out of range
      I added an "if isin" condition to rpevent the recurrent bugs also they
      are not always reproducible locally.
      
      Closes: 12520@sibi
      084e7808
    • Quentin Defenouillere's avatar
      [ing] added condition to verify the page before calling get_isin_code() · add26f8c
      Quentin Defenouillere authored and Romain Bignon's avatar Romain Bignon committed
      Several bugs occurred in production with NoneType has no attribute
      get_isin_code(), probably because the investment URL does not work or
      because some IPs are still blocked. In case the page did not load
      properly, the "if self.detailfonds.is_here()" before calling get_isin_code() avoids
      bugs during life insurance accounts synchronisation.
      add26f8c
    • Quentin Defenouillere's avatar
      [ing] Fixed excessive requests to get transaction investment ISIN codes · 3c8f8705
      Quentin Defenouillere authored and Romain Bignon's avatar Romain Bignon committed
      The ING module was performing many requests for the transaction list
      since it was performing an Async to get the ISIN code for each investment of each
      transaction (up to 1400 requests for one account history of 151
      transactions). I implemented a dictionary to store the ISIN codes and go
      to the investment details page only once per investment, thus reducing
      the amount of requests to 241 for the same history.
      The outputs of "history 1" for the same life insurance are identical
      before and after this patch.
      
      Closes: 833427@redmine
      3c8f8705
  3. Aug 22, 2018
  4. Aug 18, 2018
  5. Jul 29, 2018
  6. Jun 09, 2018
  7. May 05, 2018
  8. Mar 31, 2018
  9. Jan 14, 2018
  10. Dec 30, 2017
  11. Dec 16, 2017
  12. Dec 03, 2017
  13. Nov 18, 2017
  14. Oct 08, 2017