- Sep 16, 2018
-
-
-
Some accounts on Caisse d'Epargne (Yoga, Tendances...) have no balance, I checked on the website but the account details does not contain any balance either. These accounts cause bugs in the backend so we must remove them from self.accounts before returning the accounts list. Same for accounts that have no label at all. Closes: 6611@zendesk
-
The Boobill implementation was not done for "netpro" accounts (that have a different website structure) leading to crashes during the "assert". I added a "raise NotImplementedError" for these accounts. In addition, some private customers have not activated the e-Ddocuments yet so we must verify that subscriptions are activated before trying to fetch them. Closes : 19746@Sibi
-
-
-
-
do like other modules
-
-
Closes: 6757@zendesk
-
-
-
-
-
-
-
The subbank item was missing in the URl construction, leading to the login page instead of the subscriptions page. This was fixed by specifying the sub bank in the URL. I also specified the xpath to get all the subscribers since "//option" was way to loose and led to other unrelated elements in the HTML page. Closes: 6867@zendesk, 6868@zendesk
-
-
-
Closes: 6719@zendesk Closes: 16433@sibi
-
Columns' order changes with connections and leaded to bugs/inconsistencies
-
The API is used to get the subscriptions and the documents. The website is used to download the documents.
-
-
Sometimes the Value contains None, it should be interpreted like an empty string when validating regexp, not like string 'None'.
-
-
iter recipient: for transferable account, iter on internal and external recipients do transfer: do one-time immediate and deferred transfer
-
If it's already logged, don't look for sign in form
-
-
-
Common substitutions: weboob compat objects, unicode_literals and raw string for regexes
-
- corrected usage of dicts in a compatible way - use unicode output of responses when not fed in a JSON decoder (which handles both)
-
The lines "keys = ..." and "contacts = ..." execute in py2 but not in py3. Reason is: this code relies (not on pupose I think) on a feature that is implementation-specific (CPython 2.X): the leak of for loop iteration variables in local scope, thus permitting use of those variables after loop finished. In addition, the first line initializes a variable that shadows an existing non-local variable. This code magically worked for 2 years. But as Python3.X removes this specificity, this code is no longer valid. Blind fixes used: - replace keys local variable with keys_ - change order of loop nesting to have fonctionnaly equivalent but functional code
-
- use unicode_literals - remove explicit unicode flag on all strings - add raw flag on most regexes that lacked it - use weboob compat classes
-
This module subclassed CapDocument last. Children modules don't subclass CapDocument themselves. They subclass CapContact last. Python fails to build a proper mro on children modules since their bases order is too different.
-
Using __bases__, a Capability might appear multiple times in iter_caps(). For example, a Module inheriting CapBank and CapDocument would have CapCollection twice. This is a problem for AbstractModule which relies on iter_caps for subclassing. Instead, rely on a class' mro(), which avoid duplicates and has the added benefit of having capabilities ordered properly for subclassing.
-
The subscriptions are fetched from the document list, erasing the duplicates. The documents are all on the same page, despite the subscriptions. You may have several spaces for different subscribers. There is a security limit of 10 for the pagination.
-
if not, can crash transfer Closes: 16762@sibi
-
be more passive to avoid impulsive reaction from user (like doing twice the same transfer) it's better than raise error when transfer is done
-
-
-