- Feb 12, 2021
-
-
-
When reloading state and requesting the last page visited, when that page is one of the one in json_pages.py, we are usally logged out. This is handled in AccountJsonPage with a special Logged property. But it needs to be as well in the other pages. We do that by introducing a LoggedDetectionMixin, inherited by a SGPEJsonPage, common to all subsequent pages.
-
-
Previous commit revealed new 2FA messages. that where silenced by an ActionNeed. Here it is a Certicode Plus auth method that actually needed to be triggered.
-
Previous commit revealed new 2FA messages. that where silenced by an ActionNeed. Here it is a Certicode auth method that actually needed to be triggered.
-
To better avoid problems when changing things not common to SGEntreprise and SGProfessional, inheritance scheme is changed. A common SGPEBrowser still exists. It takes in common login steps from SocieteGeneraleLogin, and common Pro/Ent navigation. But SGProfessionalBrowser and SGEnterpriseBrowser are now each inheriting separately from SGPEBrowser. It bears importance for the few differences in 2FA handling for Ent, where it is systematic, compared to Pro. Also, dead code is deleted (browser and pages' side). And a few commenting is added.
-
The unitvalue contains a valuation hour or date, so the CleanDecimal didn't work. The regex for the unitprice was bad and didn't work with thousands (it's the French format so they're separated by a space which didn't match the regex).
-
The commit 84c940820cbe55ed7fb9a70c6341290101a1f12c changes the list of arguments passed when we initialize DispobankBrowser without making the corresponding changes in DispobankBrowser.__init__().
-
I have managed to find a pro connection with a wealth account (a compte titre). Adapt the code for the new website to fetch investments / history of wealth accounts. Follows the rework of LBP pro website: 97968cde1b646cb05f97ae33489440c5979b9256
-
Related to rework of LBP pro website: 97968cde1b646cb05f97ae33489440c5979b9256
-
Related to rework of LBP pro website: 97968cde1b646cb05f97ae33489440c5979b9256. Login was fixed in a previous commit so I can now access more connections (and especially connections with savings accounts) more easily.
-
-
For saving accounts (livret), the following entries were not recognized by the transaction pattern matching: INTERETS ACQUIS DECOMPTE D'INTERETS INTERETS BRUTS ACQUIS DECOMPTE D'INTERETS
-
-
My accounts had the ownership incorrectly reported as "Attorney" instead of "Owner". The root cause is that the name fields in the profile page are all in uppercase but in the account name they are capitalized.
-
2FA are skippable for some users. This is properly handled when 'no2fa' message is detected. But in this new case, since message was not acccounted for, 'no2fa' status was not attributed, and so skipping URL wasn't even searched for. Now, new message is added. Plus, if 'no2fa' is not attributed, in last resort, we check if a skipping URL is present. That way we can detect new cases instead of raising a wrong ActionNeed to user.
-
before the xpath was on a <td>, now it's a <p> tag
-
This id is needed by TPP for matching accounts.
-
This is done to help filtering between actual and uncertain wrongpass.
-
If we are going more than 2 times to the login page of bnpparibas and that we are already logged in, the server has a bug and starts to go into a redirect loop. (Note: This does not appear to be the case for Hellobank).
-
Can be CEL2 for account_name.
-
-
Initially only the case of "PLAFOND_SIGNATURE_DEPASSE" had to be added. But after discussions, the need to fix other cases emerged.
-
Without this fix, the iter_document will crash because of duplicate id. Sadly there was no reliable webid to base on
-
it was useless to give the BASEURL with the open
-
iban has no proper date since the given date is the date at which we want to download the document
-
-
There seems to have no pagination to be handled, I tested on an account existing since 2014, with 75 statements and there was no pagination.
-
for this kind of documents, only a month and year are given
-
multiples pages have exactly the same url ( they seems to be pages containing brut information, but they don't have the same format.) To avoid this conflict, a proper iban page detection has been added
-
The CleanText was just getting the label...
-
The first line is just some kind of header to tell the user to select an account
-
- Fix URLs without raw strings - Add CapDocument capability * Bank statements * Bank Identity document - Add defaults to BankStatementsPage.submit_form()
-
-
-
Check self.home.is_here() was raising errors too early. Users of professional accounts could not add new recipients.
-
Market accounts are situated on a specific page that is identical to the accounts page. The details of some of them can be fetched by going to the linebourse space. Unfortunately, not all of them are present, and we need to go a first time to see which accounts are available on linebourse so we don't go there for nothing.
-
-
To get accounts' iban, we have to fetch the accounts iban pdf. The request to fetch iban's pdfs has one redirect if it works properly. The redirect is the pdf page in which we get the iban. Sometimes, we have a second redirect to an unavailable pdf page even if the pdf is present on the website and can be retrieved using the same request. This leads to a BrowserHTTPSDowngrade because the last redirect isn't handled. Replacing http by https in the first redirect url seems to ensure that we get the to the iban's pdf page if it exists. I also added handling of the unavailable pdf page in the case that the pdf really doesn't exist.
-
-