Jerome Berthier authored Sep 11, 2019 and hydrargyrum committed Oct 01, 2019

When working with multiple AbstractModule inheritance you may
have Class1 and Class2 instanciated:

Class1(Module, CapBank)

Class2(AbstractModule, CapBank) (Abstract of Class1)

Instanciating a class Class2 object, its MRO contains both
Class1 and CapBank.

So when looking for Class2 capabilities, the patched method
as returning Class1 because actually Class1 is a subclass of
Capability as it inherit from Class1.

Romain Bignon authored May 26, 2019 and hydrargyrum committed Jul 05, 2019

It may contain a dict encoded with json

Sphinx will be able to use the docstring as documentation.
Also, favicon is PNG format.

ntome authored Sep 01, 2018 and Romain Bignon committed Sep 16, 2018

Using __bases__, a Capability might appear multiple times in iter_caps().
For example, a Module inheriting CapBank and CapDocument would have
CapCollection twice. This is a problem for AbstractModule which relies on
iter_caps for subclassing.

Instead, rely on a class' mro(), which avoid duplicates and has the added
benefit of having capabilities ordered properly for subclassing.

64cad1db was supposed to set fields to
NotAvailable when the backend supports filling but doesn't fill a field.

Unwanted effect was that if backend doesn't support filling at all, an
incomplete field would be set to NotAvailable.

d9b7f868 introduced a new callback
parameter but it did not use it

ntome authored Jul 06, 2017 and Romain Bignon committed Jul 08, 2017

object.__new__ only takes one argument: the class to construct.
It accepts more arguments only if __init__ is not overloaded, but it
is overloaded in Abstract*'s parent classes, so don't pass more args.

In Python 2, it was just deprecated, in Python 3, it doesn't work.

baptiste delpey authored Jun 21, 2017 and Romain Bignon committed Jul 08, 2017

This reverts commit d0a2a6bbe3054a4cb34cf8d5b0bac7e93ac3d509.

raise_from wraps the Python3 syntax "raise exc from cause" which is useful
when an exception is raised to wrap a lower-level exception.

TODO this is less efficient on python2

64cad1db let fillobj set fields to
NotAvailable if they were not set by the OBJECTS callback.

However, it overwrote even if a field was set but just incomplete. This
may be needlessly zealous:
- it may force hierarchical object trees to call fillobj recursively,
which is costly (for example Message class)
- it makes circular references fillobj harder (Thread and Message)

Vincent Ardisson authored Feb 10, 2017 and Romain Bignon committed Feb 18, 2017

Highlighting can use significant disk space. Don't enable it with "-a"
command-line flag anymore.
To enable highlighting for a particular backend, set "_highlight_el = 1"
in the backend config file.

If a backend defined a filling method and did not set all of the
required fields, the fields were still NotLoaded. Now, they are set to
NotAvailable.

This parameter allows to give a specific browser class

Vincent Ardisson authored Dec 09, 2016 and Romain Bignon committed Dec 24, 2016

As with AbstractPage, when instanciating an abstract backend, instead of
creating a dynamic type, we tweak the class inheritance and use normal
instanciation.

Using the `nofail` argument and hooking to `login` event, one can make
as much modules unittests as possible run, and skip the unittests which
require authentication or special configuration.

Tests are also run using all available backends now. This is especially
important for modules such as Amazon for which the backend has a large
influence on the website being used and the code being run.

I also changed the default values so that they match the expected type
(rather than being `None`).

Signed-off-by: Phyks (Lucas Verney) <phyks@phyks.me>

This is the same fix than commit "fix parent missing detection and
donwload" (c6cf2b81), but factorized.

It allows a backend to do requests to user by calling a registered
callback function.

In the requests manager, it locks each call to prevent multiple backends
requesting the same think at a time, from an idea of Adrien Clerc.

Closes #945

In Python 2, __repr__ and __str__ shouldn't return unicode.
This caused a problem for example when logging-debug a filter on Thumbnail.url,
as the logger couldn't encode the unicode repr.

autopep8 -a -r -i --select E111 .

Manual check.

flake8 --select W391,E302,E301,E304

autopep8 can't fix W391 even though it claims it can.
Fixed using a simple custom script.