Jerome Berthier authored Aug 19, 2020 and hydrargyrum committed Aug 26, 2020

Useful when using with a pre-push hook, it is useless to run flakes
on the whole code base every time you push.

Example of pre-push hook using this feature:

ref=$(git rev-list --boundary HEAD...master | grep "^-" | cut -c2-)
PYFILES="$(git diff ${ref} --name-only | grep -E "*.py$" | xargs)" $PWD/tools/pyflakes.sh
if [ "$?" -ne "0" ]; then
    echo >&2 "Flakes error"
    exit 1
fi

Since all code is supposed to be python3 compatible, we should not
restrict files passing through pyflakes3.

Quentin Defenouillere authored Feb 18, 2019 and Romain Bignon committed Mar 16, 2019

For Selenium modules, HEADLESS should always be set back to True before
pushing an MR.

ntome authored Jun 07, 2018 and Romain Bignon committed Jun 09, 2018

The python3 modules listing was done before going to the root weboob git
dir.

The $'xxx' syntax is not standard shell syntax so it wasn't interpreted
correctly, causing pyflakes to spit a lot of errors.
This is after porting shebang to plain sh.

Sébastien Marie authored Apr 25, 2018 and hydrargyrum committed Apr 26, 2018

- use env(1) to found bash on the system
- remove bash dependency on few scripts

The solution to check if a version is installed is not enough for CI. We
often have python2 installed, but not onfigured.

This patch stops the behaviour to run both versions, a caller must now
call the script twice to check both pythons versions. It's not perfect,
but probably easier to understand

hydrargyrum authored Jul 16, 2017 and Romain Bignon committed Jul 16, 2017

Also, fix missed warnings due to pyflakes.sh bug.
And ignore /deprecated/ in python3.

ntome authored Jun 26, 2017 and Romain Bignon committed Jul 08, 2017

Since not all modules are Python3-compatible, don't emit warnings for
all. They should be declared in a dedicated file.
All modules are checked in Python2 though.

This will generate a lot of warnings on modules since they are not
python3-compatible yet.
Use the same flag for run_tests, and use python3 by default for weboob_lint.

For future Python 3 compatibility.

Use stream.isatty() instead.

close #1404

Signed-off-by: Christophe Lampin <weboob@lampin.net>

And use exec to capture the real return code.

They were not in the tools/pyflakes.sh runs

With flake8, we can check for more issues and ignore those who are not
real issues.

This allowed me to find genuine errors in:
- modules/boursorama/pages/account_history.py
- modules/ing/pages/login.py
- weboob/tools/application/qt/qt.py
I left one in weboob/tools/browser/browser.py for the time being.

Some PEP8 fixes on other files.