baptiste delpey authored Jun 21, 2017 and Romain Bignon committed Jul 08, 2017

This reverts commit d0a2a6bbe3054a4cb34cf8d5b0bac7e93ac3d509.

raise_from wraps the Python3 syntax "raise exc from cause" which is useful
when an exception is raised to wrap a lower-level exception.

Using the `nofail` argument and hooking to `login` event, one can make
as much modules unittests as possible run, and skip the unittests which
require authentication or special configuration.

Tests are also run using all available backends now. This is especially
important for modules such as Amazon for which the backend has a large
influence on the website being used and the code being run.

I also changed the default values so that they match the expected type
(rather than being `None`).

flake8 --select W391,E302,E301,E304

autopep8 can't fix W391 even though it claims it can.
Fixed using a simple custom script.

This is a cleaner approach that requires less configuration
in other applications.
This also easily allows us to have another color.

Many checks were made on being exactly at the DEBUG level, they were
fixed to also check on being below DEBUG (i.e. DEBUG_FILTERS).

They bring nothing of value (we never use import * anyway) and introduce
a maintenance burden.

The __all__ that I left might not be very useful either but at least
they are not a pain to maintain; they are also used by pyflakes in some
cases.

autopep8 -i --select=W602
Also some other minor deprecated syntax changes, like "while 1".
I did not commit the less obvious changes.

Remove useless trailing \
Remove trailing spaces
Add missing empty lines

autopep8 -ir -j2 --select=E301,E302,E502,W291,W293,W391 .

Diff quickly checked.

Change every mention of MAINTAINER to avoid future issues.

- use an OS independant way of identifying base module directory - use a more portable way of reading stty output