Martin Sicot authored Jan 22, 2019 and Romain Bignon committed Feb 24, 2019

Transaction.label content was unreadable due to the format supplied by fortuneo. We
retrieve the more readable one every time now.
closes:9093@zendesk

Martin Sicot authored Jan 24, 2019 and Romain Bignon committed Feb 05, 2019

A choice present on the main pages threw ActionNeeded. We now chose the
option 'later' whenever connecting.
fix:9019@zendesk

Maxime Gasselin authored Dec 18, 2018 and Romain Bignon committed Dec 21, 2018

When the user enters a bad value during add recipient, the module
chrached because the get_error xpath was malformed.

Closes: 8660@zendesk

Sylvie Ye authored Dec 03, 2018 and Romain Bignon committed Dec 06, 2018

else, use errors='xmlcharrefreplace' parameter

Sylvie Ye authored Dec 03, 2018 and Romain Bignon committed Dec 06, 2018

error message is like: "Votre saisie contient le caractère ! qui n'est pas autorisé."

Maxime Gasselin authored Nov 06, 2018 and Romain Bignon committed Dec 02, 2018

Here we inform the user to use the new sms code. It happens when user
waits more than 5 minutes to enter its code. We also catch error message
when the code validation is unsuccessful.

Closes: 7689@zendesk

Martin Sicot authored Nov 08, 2018 and Romain Bignon committed Dec 02, 2018

Closes: 7432@zendesk

Sylvie Ye authored Nov 06, 2018 and Romain Bignon committed Nov 10, 2018

Iban string retrieve is like this:
IBAN : EX6713281847025700290000236 Nom du Titulaire
or
IBAN : EX6713281847025700290000236 BIC / SWIFT

Sylvie Ye authored Nov 02, 2018 and Romain Bignon committed Nov 10, 2018

iban can be in lower case and is an alphanumeric string

Quentin Defenouillere authored Oct 16, 2018 and Romain Bignon committed Nov 10, 2018

Some customers have a specific message in the iframe:
"Accès client - Sécurité renforcée
Cette opération sensible doit être validée par un code sécurité envoyé
par SMS ou serveur vocal."
Since we cannot bypass it by browsing the website or clicking on a
button are must raise ActionNeeded in this case.

This seems to concern customers who have not entered a phone number yet,
therefore I also had to correct the Regexp on the phone number in case
there is none for the CapProfile part.

Closes: 7432@zendesk

Victor Kannemacher authored Sep 27, 2018 and Romain Bignon committed Oct 11, 2018

The user can enable the reception of an otp when we download the csv.
Then we need to parse the website to get the information we need.
We will have less informations than what we have on the csv page.

Sylvie Ye authored Sep 11, 2018 and Romain Bignon committed Oct 11, 2018

there are also not in recipients transfer list

Sylvie Ye authored Sep 07, 2018 and Romain Bignon committed Oct 09, 2018

Do not use AddRecipientError for user error anymore
Use AddRecipientBankError instead and use 'assert' for program error case

Sylvie Ye authored Sep 10, 2018 and Romain Bignon committed Sep 16, 2018

Account id is not only digit for savings accounts

Quentin Defenouillere authored Sep 10, 2018 and Romain Bignon committed Sep 16, 2018

Some fortuneo connections randomly crash because the balance is not
fetched correctly and the "account.get_currency(balance)" returns:
AttributeError: 'NoneType' object has no attribute 'upper'
The "elif balance" makes sure that there is a balance before trying to
extract a currency from a NoneType.

Closes: 16284@sibi

Sylvie Ye authored Jun 07, 2018 and Romain Bignon committed Sep 16, 2018

iter recipient: for transferable account, iter on internal and external recipients
do transfer: do one-time immediate and deferred transfer

Fong NGO authored Jul 26, 2018 and Romain Bignon committed Jul 29, 2018

The iframe destination tends to change, and isn't always an AccountList
page. However, we test the existence of CGUs on the AccountsList page,
and this is why we need to ensure we are on a AccountList page
beforehand.

Closes: 14153@sibi 13797@sibi

Fong NGO authored Jun 12, 2018 and Romain Bignon committed Jul 29, 2018

The main change is allowing every iframe to be visited whatever its src attribute is,
in order to detect whether or not there are CGUs.

It replaces my previous patch (09621839c8bdbca2986b24747282b10f1f770aff)
in which i was trying to skip the action needed as well, but didn't
notice the bug still occured during the first iter_accounts() runned by
the blackbox (the patch corrected the bug during the second iter_accounts,
from the state we were left at after the first iter_accounts)

Also, some refactoring:
- don't deal with the action needed with an on_load method in AccountsPage
- test the existence of an action needed only once with an extra
attribute self.action_needed_processed

Fong NGO authored Jun 02, 2018 and Romain Bignon committed Jun 09, 2018

Previously, the bug was handled by raising an Action Needed (which
actually occurs) but we can also skip it and resume the scrapping.

Fong NGO authored May 14, 2018 and Romain Bignon committed Jun 09, 2018

In particular, the bug was due to the fact that balance wasn't available
because of the Action Needed.

Closes: 1151@sibi

Baptiste Delpey authored Mar 20, 2018 and Romain Bignon committed Mar 31, 2018

Closes: 548233@redmine

Etienne Lachere authored Jan 24, 2018 and Romain Bignon committed Feb 04, 2018

Closes: 514765@redmine

Victor Kannemacher authored Jan 18, 2018 and Romain Bignon committed Feb 04, 2018

Fortuneo don't consider a deferred card as an account but we have a
deferred amount on the account list page.

Closes : 4043@zendesk