- Apr 11, 2021
-
-
Romain Bignon authored
-
Romain Bignon authored
-
-
Roger Philibert authored
-
-
- Apr 08, 2021
-
-
-
The valuation is already in euro, not in GB pence, so it should not be converted.
-
The CleanDecimal is unnecessary when we're already fetching numbers, and it could result in unwanted conversions in scientific value, such as 0.0001 becoming 1E-04.
-
GBX is ambiguous, it's the symbol for both GB Pence and the crypto-currency GoByte. We convert them to GBP. The unitprice is in the original currency of the stock so we need to handle original_unitprice when applicable.
-
On the website, the user is asked to complete their profile. On the API, we have no error until we try to fetch the account's details. At this point we get an error 412 without much more info.
-
As the website is stateful, after being on a "History list", if we do a request for the details of one entry of the list, we will have to send the "going back" request to have the "History list" page again. But, it is not needed to "go back" to see other "details" pages. So, this change improve the performance by only going back once before trying to go to the next page of a History list page. In addition, this might fix some nasty issues as the website is "unstable" and could easily have timeout issues. And in that case, missing any step could easily break next requests with strange errors.
-
show_more() is called to select the number of items per page. It will return False if the selector was not found, and True if it was found and successfully changed to the request value. But, currently, if we found the selector but it was already on the correct value, we would return nothing, that would be equivalent to False for the "if" test that is used in the browser.py. This issue associated with a previous issue when "stay_or_go" was used, led to having the history entries returned only for a single time, for single account, but not for subsequent calls or different accounts.
-
Sometimes, instead of the expected content, an empty page with just a META redirection is returned when it looks like that the user was disconnected. Ex.: <!DOCTYPE html><html><head><META http-equiv="refresh" content="0; URL=/portal/salarie-axa/operations/consulteroperations"></head><body></body></html> A further request would encounter 302 redirections to the login page. In such a case, raise a "Loggedout" exception as previously it was just silently ignored and considered as a normal page. Note: check_disconnected as to be called manually in iter_history, as a simple "open" (compared to a "location") will not call the "on_load" function of the page.
-
The s2e website is stateful, and a lot of different content can match the same url, so it is safer to always go back to the inital page. By only using a go, we can be sure that the good page will be loaded in the correct state before trying to use any function of the page.
-
Also set the language when calling profile first before already having a cookie that had the correct language set by a call to accounts page. At the same time, to be future proof, add the xpath selectors for the us language version of the page.
-
The extracting of the Amundi AMF code was broken as we were not trying to get it from the right page. But, as it looks like that the ISIN code is available, let's get that directly instead of the AMF Code.
-
Sometimes, without logical reasons, we receive a broken login page. So detect this broken page as a BrowserUnavailable and attempt at least one retry.
-
If the login lenght exceeds 32 characters, Bred website will redirect to main page, without login user in and without error messages, which lead to raise 403 error when accessing users accounts.
-
For some accounts, the form to go to the invests page redirects to a 404. There is no detail available on the website for these accounts.
-
Previously a connection was set to wrongpass everytime there was an error even if it wasn't a real wrongpass (e.g. website unavailable)
-
Removed hardcoded unitvalue and quantity for euro funds Added original_currency
-
Access can be blocked and user must ask new credentials. Because of bank server sensitivity we musn't try a new sync or access will be blocked again; so it is actually better to treat it as BrowserIncorrectPassword. This has been discussed directly with the bank.
-
Put message in logger when token request fails to ease up log searches.
-
-
-
-
The form can be passed by clicking "No".
-
The old URL redirects to the new page of the first account, so every account had the same investments as the first account.
-
The URL has changed on Bourse Direct but not on ING.
-
The old link returns 404. If we follow the investment's link, we arrive on a new page. It's filled using javascript and API calls, which we can replicate.
-
Some client are receiving the TLS_CLIENT_CERTIFICATE auth method at first. We can ask for a fallback auth method which should be password. Seen on palatine
-
Sometimes after login process the server redirect to an url ('/fr/systeme/page-indisponible') which belong to urls used to indicate that the password has expired, even when it doesn't. In such cases BrowserPasswordExpired is raised inconsistently to users. Getting rid of this url fix that problem and the erratic redirection of bnp doesn't affects users pathways since it occurs after the login. -
-Change klass in LoanPage : Account > Loan -Add the following Loan obj_ when available : - name - total_amount - account_label - rate - maturity_date - next_payment_amount - next_payment_date
-
-
-
-
Avoid error when using random.choices, which is Py3 only.
-
The login form has changed a bit and another step is required after submitting the login form.
-
The page is currently not available. Instead of tagging all connections as websiteUnavailable we log a warning and fetch the rest of the documents.
-
The output from stderr was not properly handled on error leading to a TypeError exception
-
