- Apr 11, 2021
-
-
Romain Bignon authored
-
Romain Bignon authored
-
- Apr 08, 2021
-
-
The valuation is already in euro, not in GB pence, so it should not be converted.
-
The CleanDecimal is unnecessary when we're already fetching numbers, and it could result in unwanted conversions in scientific value, such as 0.0001 becoming 1E-04.
-
GBX is ambiguous, it's the symbol for both GB Pence and the crypto-currency GoByte. We convert them to GBP. The unitprice is in the original currency of the stock so we need to handle original_unitprice when applicable.
-
On the website, the user is asked to complete their profile. On the API, we have no error until we try to fetch the account's details. At this point we get an error 412 without much more info.
-
- Apr 04, 2021
-
-
- Feb 26, 2021
-
-
Some stocks are present in several investments in the json. On the website, they are combined in js.
-
- Dec 21, 2020
-
-
The more market orders there are in a given period, the longer the API takes to answer. Above a certain number, the API itself crashes. We fetch them two weeks at a time to avoid that.
-
The 'currency' code was complete bullshit, some customers complained that their 'EUR' account was displayed in GBP. We now go to the account details page to fetch the 'baseCurrency'.
-
Some rejected Market Orders have no ID so we skip them since will never be executed and Market Orders without IDs may cause bugs in the matching.
-
We must pass ignore_duplicate = True because the same order may appear several times in the JSON.
-
There are several new labels for the "action" field in the history query. Also, there is a request to fetch products that fails if the list of products to fetch is empty. We only do it if there is at least one id.
-
-
-
-
Some users have a 403 instead of a 400 error at login, it is still a wrongpass and the website informs that the conneciton is blocked.
-
- Apr 08, 2020
-
-
- Feb 20, 2020
-
-
- Feb 12, 2020
-
-
Romain Bignon authored
-
Romain Bignon authored
-
- Jan 08, 2020
-
-
-
The history_history parsing was completely broken. Now, all transaction have an 'id' key = 0 so we cannot retrieve proper transaction IDs anymore. The code to get the amount was wrong since there was a (self) missing for Field('raw'), we were evulating a Regexp() on the Field class itself. We do not scrape transaction.amount if it is in a different currency than the account; in these cases we only scrape the original_amoutn and the original_currency. -
Field('code') was never evaluated, my bad! -
The module didn't respect the data model for transations concerning orgininal_currency and original_amount. The acounts are in Euros but the website doesn't provide conversion so foreign amount and currencies had to be handled.
-
A few code tweaks too
-
-
-
The account balance is not available in the JSON, so we need to sum the investment valuations to get the correct value. However, it seems that investments in JPY are multiplied by 100, so we must divide this value accordingly otherwise the invest AND the account abalnce will be wrong.
-
Transactions date are displayed in the JSON in yyyy-mm-dd format but where retrieved using day_first=True. Transactions are currently lacking an id. When they get one, we can merge this MR and the transactions in the backend will be corrected.
-
The JSON after login slightly changed, now we need to use the path 'data/intAccount' instead of 'intAccount'.
-
Transactions were lacking an id. Patch related to !2547 in order to correct wrong dates in ther backend. We first add an id to map the backend, and then when this patch is live we patch with the !2547. Needs backend!1286 first.
-
-
Balance : The account balance and the total amount of the investments in that same account was not the same because of the wrong dictionnary key. original_valuation : added parse function to handle correclty investments in foreign currency liquidity : replaced the investments that are cash in the iter_investments list by liquidities.
-
Liquidites are actually inside the investment list. We were duplicating the liquiditites.
-
Liquidities were not brought up by the module because there is not a place where it is recorded. We had to deduce it from the most recent balance of the account, found in the transaction history page.
-
Some investment lists may have investments with identical ISIN ; the regular investment fund as well as the "CFD" (contract for difference) fund. In order to discriminate between the two, we prefix the CFD version with "XX-" followed by its ISIN code.
-
-
-
