From f5ee8a966e26bf9e1be41c94de00581b6e063692 Mon Sep 17 00:00:00 2001
From: Sylvie Ye <sye@budget-insight.com>
Date: Thu, 21 Mar 2019 16:34:39 +0100
Subject: [PATCH] [bnp] 'idBeneficiaire' is not stable, change recipient id

use iban as id for external recipient
---
 modules/bnporc/pp/browser.py | 6 +++---
 modules/bnporc/pp/pages.py   | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/modules/bnporc/pp/browser.py b/modules/bnporc/pp/browser.py
index a8cbe21336..33324a82ce 100644
--- a/modules/bnporc/pp/browser.py
+++ b/modules/bnporc/pp/browser.py
@@ -404,7 +404,7 @@ def send_code(self, recipient, **params):
         add recipient with sms otp authentication
         """
         data = {}
-        data['idBeneficiaire'] = recipient.id
+        data['idBeneficiaire'] = recipient._transfer_id
         data['typeActivation'] = 1
         data['codeActivation'] = params['code']
         return self.activate_recip_sms.go(data=json.dumps(data), headers={'Content-Type': 'application/json'}).get_recipient(recipient)
@@ -422,7 +422,7 @@ def new_recipient_digital_key(self, recipient, data):
         # prepare data for polling
         assert recipient._id_transaction
         polling_data = {}
-        polling_data['idBeneficiaire'] = recipient.id
+        polling_data['idBeneficiaire'] = recipient._transfer_id
         polling_data['idTransaction'] = recipient._id_transaction
         polling_data['typeActivation'] = 2
 
@@ -452,7 +452,7 @@ def prepare_transfer(self, account, recipient, amount, reason, exec_date):
         data['montant'] = str(amount)
         data['typeVirement'] = 'SEPA'
         if recipient.category == u'Externe':
-            data['idBeneficiaire'] = recipient.id
+            data['idBeneficiaire'] = recipient._transfer_id
         else:
             data['compteCrediteur'] = recipient.id
         return data
diff --git a/modules/bnporc/pp/pages.py b/modules/bnporc/pp/pages.py
index 992ddda17c..1d9b28fddb 100644
--- a/modules/bnporc/pp/pages.py
+++ b/modules/bnporc/pp/pages.py
@@ -403,9 +403,9 @@ class item(MyRecipient):
             # For the moment, only yield ready to transfer on recipients.
             condition = lambda self: Dict('libelleStatut')(self.el) in [u'Activé', u'Temporisé', u'En attente']
 
-            obj_id = Dict('idBeneficiaire')
+            obj_id = obj_iban = Dict('ibanNumCompte')
+            obj__transfer_id = Dict('idBeneficiaire')
             obj_label = Dict('nomBeneficiaire')
-            obj_iban = Dict('ibanNumCompte')
             obj_category = u'Externe'
             obj__web_state = Dict('libelleStatut')
 
@@ -440,7 +440,7 @@ def handle_response(self, account, recipient, amount, reason):
         self.abort_if_unknown(transfer_data)
 
         if 'idBeneficiaire' in transfer_data and transfer_data['idBeneficiaire'] is not None:
-            assert transfer_data['idBeneficiaire'] == recipient.id
+            assert transfer_data['idBeneficiaire'] == recipient._transfer_id
         elif transfer_data.get('ibanCompteCrediteur'):
             assert transfer_data['ibanCompteCrediteur'] == recipient.iban
 
-- 
GitLab