From e89541c93914bcbaaf7d9d3d0130545809a9ca8a Mon Sep 17 00:00:00 2001 From: Maxime Gasselin Date: Mon, 13 May 2019 18:49:55 +0200 Subject: [PATCH] [bnporc] Improve history navigation for bnp enterprise The history were returned for 3 months. Now we return it for 1 year. Moreover the patch allows to sort and return the transactions page per page. Closes: 11276@zendesk --- modules/bnporc/enterprise/browser.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/modules/bnporc/enterprise/browser.py b/modules/bnporc/enterprise/browser.py index 7996eea545..1d618fcec0 100644 --- a/modules/bnporc/enterprise/browser.py +++ b/modules/bnporc/enterprise/browser.py @@ -125,10 +125,10 @@ def iter_history(self, account): return self._iter_history_base(account) def _iter_history_base(self, account): - history = [] dformat = "%Y%m%d" - for date in rrule(MONTHLY, dtstart=(datetime.now() - relativedelta(months=3)), until=datetime.now()): + for date in rrule(MONTHLY, dtstart=(datetime.now() - relativedelta(months=12)), until=datetime.now())[::-1]: + history = [] self.account_history_view.go( identifiant=account.iban, type_solde='C', type_releve='Previsionnel', type_date='O', date_min=(date + relativedelta(days=1)).strftime(dformat), @@ -146,7 +146,8 @@ def _iter_history_base(self, account): self.logger.debug('skipping coming %r', transaction.to_dict()) continue history.append(transaction) - return sorted_transactions(history) + for transaction in sorted_transactions(history): + yield transaction @need_login def iter_coming_operations(self, account): -- GitLab