From d73ccbb754eb64c3cc834b016f25cdf66c24ce1e Mon Sep 17 00:00:00 2001 From: Guillaume Risbourg Date: Fri, 29 May 2020 17:16:11 +0200 Subject: [PATCH] [capabilities/bank] Raise asserts instead of TransferError for transfer checks --- weboob/capabilities/bank.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/weboob/capabilities/bank.py b/weboob/capabilities/bank.py index 1f430e3e40..d6ef15bac4 100644 --- a/weboob/capabilities/bank.py +++ b/weboob/capabilities/bank.py @@ -935,13 +935,10 @@ def transfer(self, transfer, **params): for key, value in t.iter_fields(): if hasattr(transfer, key) and (key not in transfer_not_check_fields[transfer.beneficiary_type]): transfer_val = getattr(transfer, key) - try: - if hasattr(self, 'transfer_check_%s' % key): - assert getattr(self, 'transfer_check_%s' % key)(transfer_val, value) - else: - assert transfer_val == value or empty(transfer_val) - except AssertionError: - raise TransferError('%s changed during transfer processing (from %s to %s)' % (key, transfer_val, value)) + if hasattr(self, 'transfer_check_%s' % key): + assert getattr(self, 'transfer_check_%s' % key)(transfer_val, value), '%s changed during transfer processing (from "%s" to "%s")' % (key, transfer_val, value) + else: + assert transfer_val == value or empty(transfer_val), '%s changed during transfer processing (from "%s" to "%s")' % (key, transfer_val, value) return self.execute_transfer(t, **params) def transfer_check_label(self, old, new): -- GitLab