From b0398c4e06ecacdb92d7f0d52429d107d7fc8a8c Mon Sep 17 00:00:00 2001 From: Quentin Defenouillere Date: Fri, 17 May 2019 11:07:41 +0200 Subject: [PATCH] [caissedepargne] Remove access_to_loans boolean It turns out this boolean is useless, after 5 tries if we didn't manage to reach the loans we just return self.loans = [] There is no need to raise BrowserUnavailable() if we didn't get there. Closes: 41162@sibi --- modules/caissedepargne/browser.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/modules/caissedepargne/browser.py b/modules/caissedepargne/browser.py index 68fc2349ae..1ee0ff09e1 100644 --- a/modules/caissedepargne/browser.py +++ b/modules/caissedepargne/browser.py @@ -445,7 +445,6 @@ def get_loans_list(self): if self.page.check_no_accounts() or self.page.check_no_loans(): return [] - access_to_loans = False for trial in range(5): for _ in range(3): self.home_tache.go(tache='CRESYNT0') @@ -461,12 +460,8 @@ def get_loans_list(self): self.logger.warning('Access to loans failed, we try again') else: # We managed to reach the Loans JSON - access_to_loans = True break - if not access_to_loans: - raise BrowserUnavailable() - for _ in range(3): try: self.home_tache.go(tache='CPTSYNT0') -- GitLab