From 9c1b594126b53c293c6b304fa30c2feb5fa7c64a Mon Sep 17 00:00:00 2001
From: Jerome Berthier <jerome.berthier@budget-insight.com>
Date: Thu, 4 Jul 2019 14:44:29 +0200
Subject: [PATCH] Revert "[banquepopulaire] raise incorrect password if
 password is not digits only"

This reverts commit 5430274b965a109a5e6b672eabf35479cadecaa1.
---
 modules/banquepopulaire/pages.py | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/modules/banquepopulaire/pages.py b/modules/banquepopulaire/pages.py
index 22de573cb2..9186fc040c 100644
--- a/modules/banquepopulaire/pages.py
+++ b/modules/banquepopulaire/pages.py
@@ -379,12 +379,6 @@ def virtualkeyboard(self, vk_obj, password):
         return MyVirtKeyboard(imgs).get_string_code(password)
 
     def login(self, login, password):
-
-        # All users must have a password with digits only, else the website is broken.
-        # It accepts the login but fails miserably, raising a real BrowserUnavailable (like in Firefox)
-        if not password.isdigit():
-           raise BrowserIncorrectPassword()
-
         payload = {
             'validate': {
                 self.form_id[0]: [ {
@@ -406,6 +400,9 @@ def login(self, login, password):
                     form_id = (k, v[0]['id'], v[0]['type'])
 
                 if v[0].get('virtualKeyboard'):
+                    if not password.isdigit():
+                        # Users who get the virtual keyboard needs a password with digits only
+                        raise BrowserIncorrectPassword()
                     password = self.virtualkeyboard(vk_obj=v[0]['virtualKeyboard'],
                                                     password=password)
 
-- 
GitLab