From 8ce50c2fe7a69c67fb8f201f68fda35f6a34e669 Mon Sep 17 00:00:00 2001 From: Quentin Defenouillere Date: Thu, 7 May 2020 16:42:55 +0200 Subject: [PATCH] weboob.capabilities.bank: Added MarketOrder execution_date On some websites we observe 3 dates: validity_date, creation date and execution date. The 'date' attribute is set to the creation_date since all market orders have one, whereas some market orders (that are still ongoing, or that have been refused or cancelled) have no execution_date, and the date is often used to sort the orders chronologically. --- weboob/capabilities/bank.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/weboob/capabilities/bank.py b/weboob/capabilities/bank.py index 29e3e24b08..8f9f5c2f50 100644 --- a/weboob/capabilities/bank.py +++ b/weboob/capabilities/bank.py @@ -638,8 +638,9 @@ class MarketOrder(BaseObject): # MarketOrder additional information order_type = EnumField('Type of market order', MarketOrderType, default=MarketOrderType.UNKNOWN) direction = EnumField('Direction of the market order (buy or sale)', MarketOrderDirection, default=MarketOrderDirection.UNKNOWN) - date = DateField('Date when the market order was executed') + date = DateField('Creation date of the market order') validity_date = DateField('Validity date of the market order') + execution_date = DateField('Execution date of the market order (only for market orders that are completed)') state = StringField('Current state of the market order (e.g. executed)') code = StringField('Identifier of the stock related to the order') stock_market = StringField('Stock market on which the order was executed') -- GitLab