From 85c4e887eb5ba3efa04ee8da0f2e191d24ddf29a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9lande=20Adrien?= <celande.adrien@budget-insight.com>
Date: Mon, 13 Aug 2018 15:43:21 +0200
Subject: [PATCH] [caissedepargne] '-' corner case for recipient

People may have a '-' in their name.
So now the strign is splitted instead of just excluding '-' with a regex.

Closes: 16506@sibi
Closes: 16507@sibi
Closes: 16393@sibi
Closes: 12916@sibi
---
 modules/caissedepargne/pages.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/modules/caissedepargne/pages.py b/modules/caissedepargne/pages.py
index 760c6392b9..714e59e018 100644
--- a/modules/caissedepargne/pages.py
+++ b/modules/caissedepargne/pages.py
@@ -883,12 +883,15 @@ def parse(self, el):
                 self.env['label'] = mtc.group('label')
             # Fcking corner case
             else:
-                mtc = re.match('(?P<id>.+) - (?P<label>[^-]+) -( [^-]*)?-?$', CleanText('.')(self))
-                assert mtc
-                self.env['id'] = mtc.group('id')
+                # former regex: '(?P<id>.+) - (?P<label>[^-]+) -( [^-]*)?-?$'
+                # the strip is in case the string ends by ' -'
+                mtc = CleanText('.')(self).strip(' -').split(' - ')
+                # it needs to contain, at least, the id and the label
+                assert len(mtc) >= 2
+                self.env['id'] = mtc[0]
                 self.env['iban'] = NotAvailable
                 self.env['bank_name'] = NotAvailable
-                self.env['label'] = mtc.group('label')
+                self.env['label'] = mtc[1]
 
 
 class TransferPage(TransferErrorPage, IndexPage):
-- 
GitLab