From 7ef2fa3e06ebf838896e34243e4e7a11426bf3e5 Mon Sep 17 00:00:00 2001
From: Florent Viard <florent.viard@budget-insight.com>
Date: Thu, 29 Oct 2020 17:21:22 +0100
Subject: [PATCH] tools/har-to-old: Replace the "prefix" argument with an
 optional "destdir"

The previous syntax for har-to-old was:

    usage: har-to-old.py [-h] file prefix

Change it to:

    usage: har-to-old.py [-h] file [destdir]

- prefix renamed in destdir, as it was not really a prefix but the
name(/path) to the destination folder for extracted files
- automatically create the destdir folder if it does not exist
- if destdir is not provided, use the file name without extension
---
 tools/har-to-old.py | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/tools/har-to-old.py b/tools/har-to-old.py
index fa2061641e..ccf28289bc 100755
--- a/tools/har-to-old.py
+++ b/tools/har-to-old.py
@@ -4,6 +4,7 @@
 from base64 import b64decode
 import json
 import mimetypes
+import os
 from pathlib import Path
 from urllib.parse import urlparse
 
@@ -58,12 +59,14 @@ def guess_extension(entry):
 
 
 def main():
-    def extract(n, prefix):
+    def extract(n, destdir):
+        os.makedirs(destdir, exist_ok=True)
+
         entry = data['log']['entries'][n]
 
         ext = guess_extension(entry)
         name = Path(urlparse(entry['request']['url']).path).stem
-        prefix = f'{prefix}/{n + 1:03d}-{entry["response"]["status"]}{name and f"-{name}"}{ext}'
+        prefix = f'{destdir}/{n + 1:03d}-{entry["response"]["status"]}{name and f"-{name}"}{ext}'
 
         with open(f'{prefix}-request.txt', 'wb') as fd:
             write_request(entry, fd)
@@ -74,13 +77,20 @@ def extract(n, prefix):
 
     parser = ArgumentParser()
     parser.add_argument('file', type=FileType('r'), help='HAR file to extract')
-    parser.add_argument('prefix')
+    parser.add_argument('destdir', nargs='?', default=None, help='Destination directory for extracted files')
     args = parser.parse_args()
 
+    if args.destdir is None:
+        # Automatically generate destdir if not provided
+        if args.file.name.endswith('.har'):
+            args.destdir = args.file.name[:-4]
+        else:
+            args.destdir = f'{args.file.name}_content'
+
     data = json.load(args.file)
     for n in range(len(data['log']['entries'])):
         print('extracting request', n)
-        extract(n, args.prefix)
+        extract(n, args.destdir)
 
 
 if __name__ == '__main__':
-- 
GitLab