Commit 36a9bd4d authored by Quentin Defenouillere's avatar Quentin Defenouillere Committed by Vincent A

[carrefourbanque] Fix card history and balance

The card index was hardcoded to "0" so we were always fetching the same
transactions for all cards.
Also handled balance for cards that don't have an "en cours" balance.
Also handled the "no transaction" case.
parent 47a46350
......@@ -19,6 +19,7 @@
from __future__ import absolute_import, unicode_literals
import re
from time import sleep
from weboob.browser import LoginBrowser, URL, need_login, StatesMixin
......@@ -163,6 +164,8 @@ class CarrefourBanqueBrowser(LoginBrowser, StatesMixin):
elif account.type == Account.TYPE_CARD:
assert self.card_history.is_here()
card_index ='[?&]index=(\d+)', account.url).group(1)
previous_date =
# the website stores the transactions over more or less 1 year
# the transactions are displayed 40 by 40 in a dynamic table
......@@ -176,7 +179,7 @@ class CarrefourBanqueBrowser(LoginBrowser, StatesMixin):
# if we do the call without sending a dateRecup it will return the 40 first transactions twice
# it will also do with a random timestamp
# in this particular case dateRecup can be any value as long as it's not an empty string or a timestamp
self.card_history_json.go(data={'dateRecup': 'needToNotBeEmpty', 'index': 0})
self.card_history_json.go(data={'dateRecup': 'needToNotBeEmpty', 'index': card_index})
previous_date =
if previous_date:
......@@ -184,7 +187,7 @@ class CarrefourBanqueBrowser(LoginBrowser, StatesMixin):
total = 0
loop_limit = 500
for page in range(loop_limit):
self.card_history_json.go(data={'dateRecup': previous_date, 'index': 0})
self.card_history_json.go(data={'dateRecup': previous_date, 'index': card_index})
previous_date =
it = iter(
......@@ -35,7 +35,7 @@ from weboob.browser.filters.html import Link, TableCell, Attr, AttributeNotFound
from weboob.browser.filters.json import Dict
from import Account
from weboob.capabilities.wealth import Investment
from weboob.capabilities.base import NotAvailable
from weboob.capabilities.base import NotAvailable, empty
from import FrenchTransaction
from weboob.exceptions import ActionNeeded
......@@ -195,7 +195,9 @@ class item_account_generic(ItemElement):
def obj_balance(self):
balance = CleanDecimal('.//div[contains(@class, "right_col")]//h2[1]', replace_dots=True)(self)
return (-balance if Field('type')(self) in (Account.TYPE_LOAN,) else balance)
if Field('type')(self) in (Account.TYPE_LOAN, ):
return -balance
return balance
obj_currency = Currency('.//div[contains(@class, "right_col")]//h2[1]')
obj_label = CleanText('.//div[contains(@class, "leftcol")]//h2[1]')
......@@ -250,8 +252,32 @@ class HomePage(LoggedPage, HTMLPage):
obj_type = Account.TYPE_CARD
def obj_balance(self):
available = CleanDecimal('.//p[contains(., "encours depuis le")]//preceding-sibling::h2', default=None, replace_dots=True)(self)
return NotAvailable if not available else -available
available = CleanDecimal(
'.//p[contains(., "encours depuis le")]//preceding-sibling::h2',
if available is not None:
return -available
# No "en cours" available: return - (total_amount - available_amount)
total_amount = CleanDecimal.French(
CleanText('.//p[text()[contains(., "plafond de")]]'),
r'plafond de ([0-9, ]+)',
available_amount = CleanDecimal.French(
'.//p[contains(text(), "disponibles à crédit")]//preceding-sibling::h2',
if empty(total_amount) or empty(available_amount):
return NotAvailable
return - (total_amount - available_amount)
class iter_saving_accounts(ListElement): # livrets
......@@ -367,6 +393,11 @@ class CardHistoryJsonPage(LoggedPage, JsonPage):
if isinstance(self.doc['tab_historique'], dict):
self.doc['tab_historique'] = sorted(self.doc['tab_historique'].values(), key=lambda x: x['timestampOperation'], reverse=True)
elif self.doc['tab_historique'] is None:
# No transaction available, set value to empty dict
# instead of null since we need an iterable
self.doc['tab_historique'] = {}
class iter_history(DictElement):
item_xpath = 'tab_historique'
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment