Commit 27345b43 authored by Florian Duguet's avatar Florian Duguet Committed by Romain Bignon

[edf - par] fix login

they have removed captcha, but added an otp at first login
then use password for other attemps, so we use a StatesMixin

Closes: 36486@sibi 36670@sibi 36669@sibi
parent e172a5a9
......@@ -42,7 +42,7 @@ class EdfModule(Module, CapDocument, CapProfile):
ValueBackendPassword('password', label='Mot de passe'),
Value('website', label='Type de compte', default='par',
choices={'par': 'Particulier', 'pro': 'Entreprise'}),
Value('captcha_response', label='Reponse Captcha', required=False, default=''))
Value('otp', label='Entrez le code reçu par SMS', required=False))
accepted_document_types = (DocumentTypes.BILL,)
......@@ -20,13 +20,13 @@
from time import time
from weboob.browser import LoginBrowser, URL, need_login
from weboob.browser.exceptions import ClientError
from weboob.exceptions import BrowserIncorrectPassword, NocaptchaQuestion
from weboob.browser import LoginBrowser, URL, need_login, StatesMixin
from weboob.exceptions import BrowserIncorrectPassword, BrowserQuestion
from import retry
from import json
from import Value
from .pages import (
HomePage, AuthenticatePage, AuthorizePage, CheckAuthenticatePage, ProfilPage,
HomePage, AuthenticatePage, AuthorizePage, WrongPasswordPage, CheckAuthenticatePage, ProfilPage,
DocumentsPage, WelcomePage, UnLoggedPage, ProfilePage, BillDownload,
......@@ -35,13 +35,15 @@ class BrokenPageError(Exception):
class EdfBrowser(LoginBrowser):
class EdfBrowser(LoginBrowser, StatesMixin):
home = URL('/fr/accueil/contrat-et-conso/mon-compte-edf.html', HomePage)
authenticate = URL(r'', AuthenticatePage)
authorize = URL(r'', AuthorizePage)
wrong_password = URL(r'', WrongPasswordPage)
check_authenticate = URL('/services/rest/openid/checkAuthenticate', CheckAuthenticatePage)
user_status = URL('/services/rest/checkuserstatus/getUserStatus')
not_connected = URL('/fr/accueil/connexion/mon-espace-client.html', UnLoggedPage)
connected = URL('/fr/accueil/espace-client/tableau-de-bord.html', WelcomePage)
profil = URL('/services/rest/authenticate/getListContracts', ProfilPage)
......@@ -54,52 +56,96 @@ class EdfBrowser(LoginBrowser):
r'&di=(?P<di>.*)&bn=(?P<bn>.*)&an=(?P<an>.*)', BillDownload)
profile = URL('/services/rest/context/getCustomerContext', ProfilePage)
__states__ = ['id_token1']
def __init__(self, config, *args, **kwargs):
self.config = config
self.authId = None
self.otp_data = None
self.otp_url = None
self.id_token1 = None
kwargs['username'] = self.config['login'].get()
kwargs['password'] = self.config['password'].get()
super(EdfBrowser, self).__init__(*args, **kwargs)
def locate_browser(self, state):
def do_login(self):
# ********** admire how login works on edf par website **********
# login part on edf particulier website is very tricky
# FIRST time we connect we have an otp, BUT not password, we can't know if it is wrong at this moment
# SECOND time we use password, and not otp
auth_params = {'realm': '/INTERNET'}
if self.config['captcha_response'].get() and self.authId:
if self.config['otp'].get():
self.otp_data['callbacks'][0]['input'][0]['value'] = self.config['otp'].get()
self.authenticate.go(json=self.otp_data, params=auth_params)
self.id_token1 =['callbacks'][1]['output'][0]['value']
# id_token1 is VERY important, we keep it indefinitely, without it edf will ask again otp
self.location('/bin/edf_rc/servlets/sasServlet', params={'processus': 'TDB'})
if self.connected.is_here():
# we are already logged
# sometimes even if password is wrong, you can be logged if you retry'already logged')
self.otp_url = self.url
self.authenticate.go(method='POST', params=auth_params)
data =
data['authId'] = self.authId
data['callbacks'][0]['input'][0]['value'] = self.username
data['callbacks'][1]['input'][0]['value'] = self.password
data['callbacks'][2]['input'][0]['value'] = self.config['captcha_response'].get()
data['callbacks'][3]['input'][0]['value'] = '0'
self.authenticate.go(json=data, params=auth_params)
except ClientError as error:
resp = error.response
if resp.status_code == 401:
raise BrowserIncorrectPassword(resp.json()['message'])
self.session.cookies['ivoiream'] =['tokenId']
# go to this url will auto submit a form which will finalize login
call check_authenticate url before get subscription in profil, or we'll get an error 'invalid session'
we do nothing with this response (which contains false btw)
but edf website expect we call it before or will reject us
self.authenticate.go(method='POST', params=auth_params)
data =
website_key = data['callbacks'][4]['output'][0]['value']
website_url = ""
self.authId = data['authId']
raise NocaptchaQuestion(website_key=website_key, website_url=website_url)
self.authenticate.go(json=data, params=auth_params)
data = # yes, we have to get response and send it again, beautiful isn't it ?
if data['stage'] == 'UsernameAuth2':
# username is wrong
raise BrowserIncorrectPassword(data['callbacks'][1]['output'][0]['value'])
if self.id_token1:
data['callbacks'][0]['input'][0]['value'] = self.id_token1
# the FIRST time we connect, we don't have id_token1, we have no choice, we'll receive an otp
data['callbacks'][0]['input'][0]['value'] = ' '
self.authenticate.go(json=data, params=auth_params)
data =
assert data['stage'] in ('HOTPcust3', 'PasswordAuth2'), 'stage is %s' % data['stage']
if data['stage'] == 'HOTPcust3': # OTP part
if self.id_token1:
# this shouldn't happen except if id_token1 expire one day, who knows...
self.logger.warning('id_token1 is not null but edf ask again for otp')
# a legend say this url is the answer to life the universe and everything, because it is use EVERYWHERE in login
self.authenticate.go(, params=auth_params)
self.otp_data =
label = self.otp_data['callbacks'][0]['output'][0]['value']
raise BrowserQuestion(Value('otp', label=label))
if data['stage'] == 'PasswordAuth2': # password part
data['callbacks'][0]['input'][0]['value'] = self.password
self.authenticate.go(, params=auth_params)
# should be SetPasAuth2 if password is ok
if['stage'] == 'PasswordAuth2':
attempt_number =['callbacks'][1]['output'][0]['value']
# attempt_number is the number of wrong password
msg = self.wrong_password.go().get_wrongpass_message(attempt_number)
raise BrowserIncorrectPassword(msg)
data =
# yes, send previous data again, i know i know
self.authenticate.go(json=data, params=auth_params)
self.session.cookies['ivoiream'] =
call check_authenticate url before get subscription in profil, or we'll get an error 'invalid session'
we do nothing with this response (which contains false btw)
but edf website expect we call it before or will reject us
def get_csrf_token(self):
return self.csrf_token.go(timestamp=int(time())).get_token()
......@@ -24,7 +24,7 @@ from decimal import Decimal
from weboob.browser.filters.html import Attr
from weboob.browser.pages import LoggedPage, JsonPage, HTMLPage, RawPage
from weboob.browser.filters.standard import Env, Format, Date, Eval
from weboob.browser.filters.standard import Env, Format, Date, Eval, CleanText, Regexp
from weboob.browser.elements import ItemElement, DictElement, method
from weboob.browser.filters.json import Dict
from weboob.capabilities.bill import DocumentTypes, Bill, Subscription
......@@ -43,6 +43,9 @@ class AuthenticatePage(JsonPage):
def get_data(self):
return self.doc
def get_token(self):
return self.doc['tokenId']
class AuthorizePage(HTMLPage):
def on_load(self):
......@@ -50,6 +53,20 @@ class AuthorizePage(HTMLPage):
class WrongPasswordPage(HTMLPage):
def get_wrongpass_message(self, attempt_number):
# edf website block access after 5 wrong password, and user will have to change his password
# this is very important because it can tell to user how much attempt it remains
script = CleanText('//script[contains(text(), "Mot de passe incorrect")]')
if attempt_number > 0:
return Format('%s %s %s',
Regexp(script, r">(Mot de passe incorrect.*?)<"),
CleanText('//div[@class="arrow_box--content"]', children=False), int(attempt_number))(self.doc)
return Regexp(script, r">(Vous avez atteint.*?)<")(self.doc)
class WelcomePage(LoggedPage, HTMLPage):
......@@ -62,7 +79,11 @@ class UnLoggedPage(HTMLPage):
class ProfilPage(LoggedPage, JsonPage):
class ProfilPage(JsonPage):
def logged(self):
return self.doc['errorCode'] == 0
class iter_subscriptions(DictElement):
item_xpath = 'customerAccordContracts'
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment