From 0a4e346c53018328b870985d92b24eb035e46fab Mon Sep 17 00:00:00 2001
From: Baptiste Delpey <bdelpey@budget-insight.com>
Date: Fri, 10 May 2019 16:56:22 +0200
Subject: [PATCH] Revert "[caissedepargne] Add try/except on Loans request"

This reverts commit 54d4de1023903b47e883e505efe74b9b1bf2a6b5.
---
 modules/caissedepargne/browser.py | 29 +++++++++--------------------
 1 file changed, 9 insertions(+), 20 deletions(-)

diff --git a/modules/caissedepargne/browser.py b/modules/caissedepargne/browser.py
index 1da54ec992..2758019cdd 100644
--- a/modules/caissedepargne/browser.py
+++ b/modules/caissedepargne/browser.py
@@ -32,7 +32,7 @@
 from weboob.capabilities.bank import Account, AddRecipientStep, Recipient, TransferBankError, Transaction, TransferStep
 from weboob.capabilities.base import NotAvailable
 from weboob.capabilities.profile import Profile
-from weboob.browser.exceptions import BrowserHTTPNotFound, ClientError, ServerError
+from weboob.browser.exceptions import BrowserHTTPNotFound, ClientError
 from weboob.exceptions import (
     BrowserIncorrectPassword, BrowserUnavailable, BrowserHTTPError, BrowserPasswordExpired, ActionNeeded
 )
@@ -445,26 +445,15 @@ def get_loans_list(self):
                 if self.page.check_no_accounts() or self.page.check_no_loans():
                     return []
 
-            access_to_loans = False
-            max_count = 0
-            while not access_to_loans and max_count < 5:
-                for _ in range(3):
-                    self.home_tache.go(tache='CRESYNT0')
-                    if self.home.is_here():
-                        break
+            for _ in range(3):
+                self.home_tache.go(tache='CRESYNT0')
                 if self.home.is_here():
-                    if not self.page.is_access_error():
-                        # The server often returns a 520 error (Undefined):
-                        try:
-                            self.loans = list(self.page.get_real_estate_loans())
-                            self.loans.extend(self.page.get_loan_list())
-                        except ServerError:
-                            self.logger.warning('Access to loans failed, we try again')
-                            max_count += 1
-                        else:
-                            access_to_loans = True
-            if not access_to_loans:
-                raise BrowserUnavailable()
+                    break
+
+            if self.home.is_here():
+                if not self.page.is_access_error():
+                    self.loans = list(self.page.get_real_estate_loans())
+                    self.loans.extend(self.page.get_loan_list())
 
             for _ in range(3):
                 try:
-- 
GitLab