Skip to content
  • Laurent Bachelier's avatar
    Make Collection more safe and sane · b4b71829
    Laurent Bachelier authored
    * Remove callbacks in Collection object
      Make Collection a "dumb" object (and also a base object,
      though it isn't very useful for now)
    * Rename Path to WorkingPath, because it is more about managing state
      than being a single path.
    * Rewrite almost all WorkingPath, because the code was overly
      complicated for no reason (I tried some special cases and it turned
      out that fromstring didn't handle them, and that the
      quote-escape-unquote was just unecessary). I also rewrote it to be
      more pythonic (no more lambdas and maps) and added tests.
    * Require the full split path when creating a Collection. Because, come to
      think of it, an object needs an unique identifier; in the case of
      Collections, it is the full path, not only its last part.
      I might even replace the id by the full split path in the future.
    * There is now only one way to get items of a Collection: calling
      iter_resources().
    * Rewrite flatten_resources to iter_resources_flat(), which just calls
      iter_resources() recursively.
    * Rewrite the collection part of the canalplus module. There is no more
      callback or a page calling the browser to check another page!
      The logic is only in iter_resources().
      The resulting code is not very pretty, but it should get better.
      As a bonus, avoid to reload the main XML file when we already have it
      open.
    * change_path() now expects a split path and not a string.
    * up/home special cases for "cd" are handled in the same place, and
      store the previous place properly (but are not yet exploitable by
      an user command).
    
    This is a big commit but it would be hard to split it in *working*
    commits.
    
    If you read this entire commit message, I will buy you a beer.
    
    refs #774
    fixes #773
    b4b71829